Moti Asayag has submitted this change and it was merged. Change subject: core: Fixed GetAllDisksByVmIdQueryTest ......................................................................
core: Fixed GetAllDisksByVmIdQueryTest The test silently assumed that a disk could have a snapshot which is the disk itself, which is an illegal state. Since change I6bfc9c6a this state became not only (silently) illegal, but actually caused a StackOverflowError. This behavior is inconsequential to the test, which dones't really care what snapshots are assossiated to the disk, as long as there are some. This patch creates new random snapshots for the disk, instead of just reusing the same object. Change-Id: Ib069780c99a04317a02d5017764c15528f931846 --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllDisksByVmIdQueryTest.java 1 file changed, 34 insertions(+), 14 deletions(-) Approvals: Allon Mureinik: Verified Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib069780c99a04317a02d5017764c15528f931846 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
