Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: Update task status everytime while querying
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRemoveBricksStatusQuery.java
Line 87: step.setStatus(status);
Line 88: getJobRepository().updateStep(step);
Line 89: }
Line 90:
Line 91: releaseVolumeLock(task.getTaskId());
Will add a condition like
if (task.getStatus() == JobExecutionStatus.FINISHED) {
releaseVolumeLock(task.getTaskId());
}
Hope that would suffice.
Line 92: }
Line 93:
Line 94: private GlusterVolumeTaskStatusEntity
fetchRemobeBricksStatusDetails() {
Line 95: VDSReturnValue returnValue =
Line 109: }
Line 110:
Line 111: // Update the latest status details for task steps.
Line 112: // This is required to make sure the engine details are
up-to-date
Line 113: updateTaskStepDetails(asyncTask,
entity.getStatusSummary().getStatus());
Will do that
Line 114:
Line 115: // If the task status at engine side is aborted, set the
same to current status
Line 116: // This is required because even in case of retention of
the brick the gluster returns
Line 117: // the status as finished and to avoid enabling of retain
and commit in ui the status should
--
To view, visit http://gerrit.ovirt.org/21005
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e8fa7ab590e15ee5821ae2f3fb41650c195c0fa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
