Sahina Bose has posted comments on this change.
Change subject: gluster: Update task status everytime while querying
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRemoveBricksStatusQuery.java
Line 71: }
Line 72:
Line 73: private void updateTaskStepDetails(GlusterAsyncTask task,
JobExecutionStatus status, List<Step> steps) {
Line 74: // If the job is already stopped no need to update the status
Line 75: if (task.getStatus() == JobExecutionStatus.ABORTED) {
Shouldn't the check be that if task status is same as step status, then return?
Line 76: return;
Line 77: }
Line 78:
Line 79: // update status in step table
--
To view, visit http://gerrit.ovirt.org/21005
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e8fa7ab590e15ee5821ae2f3fb41650c195c0fa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
