Alon Bar-Lev has posted comments on this change. Change subject: userportal, webadmin: refactor: add model attribute for help tags ......................................................................
Patch Set 2: (1 comment) Hi, Great! However, I prefer structural syntax so we can parse it easily. Still think the syntax of "dialog=,tab=,button=" is good, unless someone come out with better notation. Also, I do not understand why the hash is still used in this context, can you please explain? Thanks! .................................................... Commit Message Line 5: CommitDate: 2013-11-07 12:15:06 -0500 Line 6: Line 7: userportal, webadmin: refactor: add model attribute for help tags Line 8: Line 9: Simple refactor to add a model attribute for storing the help tag. Previously we were using the please stop at column 78 or so... Line 10: hashname to achieve help URL mapping to dialogs. Help mapping deserves its own attribute. Line 11: Line 12: setHelpTag() also takes a comment as a parameter. The comment is a description of where in Line 13: webadmin or userportal one can navigate to find this dialog / model. The comment is not currently -- To view, visit http://gerrit.ovirt.org/21052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4074fcc2ecfcbdd2ea6c0855d92f2aa4bd26a5b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
