Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: refactor: add model attribute for help tags ......................................................................
Patch Set 3: We decided on 2 fields in our etherpad discussion. I summarized here: https://bugzilla.redhat.com/show_bug.cgi?id=1014859#c5 Basically, since I am not adding structured helpTag for now, I'll re-use the hashName string as the helpTag. And, since we need the comments to live in the code for generation purposes (per Einav), I just added any existing comments as a second parameter. Note that not every setHelpTag call has a comment, so the helpTag itself is necessary. I don't know when/if we'll do a structured helpTag. As I said, that is a ton of work, and it's up to Einav if she wants me to do that. For now, she doesn't. Again, it's not really related to this problem -- it's scope creep. It should be it's own BZ in my opinion. -- To view, visit http://gerrit.ovirt.org/21052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4074fcc2ecfcbdd2ea6c0855d92f2aa4bd26a5b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
