Federico Simoncelli has posted comments on this change.
Change subject: backend: prevent live storage migration on live snapshot failure
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 310:
TransactionSupport.executeInScope(TransactionScopeOption.Suppress, new
TransactionMethod<Void>() {
Line 311: @Override
Line 312: public Void runInTransaction() {
Line 313: runVdsCommand(VDSCommandType.Snapshot,
buildLiveSnapshotParameters(snapshot));
Line 314: getParameters().setLiveSnapshotSucceeded(true);
The volumes can't be safely reverted because if the SPM fails to remove the
volumes (e.g. if the vm is running on the SPM and the host crashed) then at the
next snapshot we'll most likely create a tree.
Line 315: return null;
Line 316: }
Line 317: });
Line 318: } catch (VdcBLLException e) {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDisksTaskHandler.java
Line 25: }
Line 26:
Line 27: @Override
Line 28: public void execute() {
Line 29: if
(!enclosingCommand.getParameters().getLiveSnapshotSucceeded()) {
SEAT = Serial Execution of Asynchronous Tasks.
Line 30: throw new VdcBLLException(VdcBllErrors.imageErr,
Line 31: "Auto-generated live snapshot for VM " +
enclosingCommand.getParameters().getVmId() + " failed");
Line 32: }
Line 33:
--
To view, visit http://gerrit.ovirt.org/20668
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c69f663836e74691c968f4a15c5f3012479a8b0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
