Arik Hadas has posted comments on this change.
Change subject: backend: prevent live storage migration on live snapshot failure
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 249:
Line 250: incrementVmGeneration();
Line 251:
Line 252: endActionOnDisks();
Line 253: setSucceeded(taskGroupSucceeded && (!liveSnapshotRequired ||
liveSnapshotSucceeded));
I would prefer to do: !(liveSnapshotRequired && !liveSnapshotSucceeded) because
imo it represents the way we think of it better, but this is subjective I
guess..
Line 254: getReturnValue().setEndActionTryAgain(false);
Line 255: }
Line 256:
Line 257: private void logMemorySavingFailed() {
--
To view, visit http://gerrit.ovirt.org/20668
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c69f663836e74691c968f4a15c5f3012479a8b0
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
