Alexander Wels has posted comments on this change. Change subject: utils: pki-resource: cleanup: levarage enum methods for content type ......................................................................
Patch Set 6: With the toString on the format I can write Format.X509_PEM(PKIResource.ENGINE_CERTIFICATE) which reads better than PKIResource.ENGINE_CERTIFICATE.getAsString(Format.X509_PEM) I do not understand how codifying the interface in an enum is worse than codifying the interface in a constant string. They are both constant, and they are both hard coded. As for 1. The difference is that the static initialization is in the enum, not in the servlet. Also if you notice there is no longer a need to do getInstance() to get some reference to a singleton (no more serialization issues). -- To view, visit http://gerrit.ovirt.org/21073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24da0ff174599ffdeabbf5846eab429bf0d6510d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
