Alexander Wels has posted comments on this change.
Change subject: utils: pki-resource: cleanup: levarage enum methods for content
type
......................................................................
Patch Set 6:
> this is dependency between public interface and internal implementation.
> public interface should be detached from internal naming.
How is that a dependency, and having a map, that maps a string to an
PKIResources object, and us doing a get on that map not a dependency?
resources = new HashMap<String, PKIResources.Resource>();
resources.put("ca-certificate", PKIResources.Resource.CACertificate);
resources.put("engine-certificate", PKIResources.Resource.EngineCertificate);
Would it make you feel better if I did:
resources = new HashMap<String, PKIResources.Resource>();
resources.put("ca-certificate", PKIResources.CA_CERTIFICATE);
resources.put("engine-certificate", PKIResources.ENGINE_CERTIFICATE);
and the same for the format?
--
To view, visit http://gerrit.ovirt.org/21073
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24da0ff174599ffdeabbf5846eab429bf0d6510d
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
