Alissa Bonas has posted comments on this change.
Change subject: core: allow identical path for different local domains
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionCommandBase.java
Line 54: return
getStorageDomainDao().getAllByConnectionId(Guid.createGuidFromString(connectionId));
Line 55: }
Line 56:
Line 57: protected Guid getStoragePoolIdByFileConnectionId(String
connectionId) {
Line 58: List<StorageDomain> storageDomains =
getStorageDomainsByConnId(connectionId);
worth to mention perhaps in javadoc that this method not work well for iscsi...
because multiple domains can use the same connection (connection=target)
Line 59: if (storageDomains.isEmpty()) {
Line 60: return null;
Line 61: }
Line 62:
--
To view, visit http://gerrit.ovirt.org/20886
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4628d7fa442b959d5582e44386f31518b98852e7
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
