Liron Ar has posted comments on this change.
Change subject: backend, restapi: Add read-only disk functionality
......................................................................
Patch Set 18: Code-Review+1
(1 comment)
+1, still don't agree about the equals/hashCode method in VmDevice
conceptually, as there's no bug it's fine by me.
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
Line 281:
Line 282: initializeCommand(parameters);
Line 283: command.executeVmCommand();
Line 284:
Line 285: device.setIsReadOnly(true);
suggestions:
1. I'd add here an assertion (true) of shouldUpdateReadOnly
2. I'd add a test that when this property isn't changed, we don't perform
operations.
Line 286: verify(vmDeviceDAO, times(1)).update(device);
Line 287: }
Line 288:
Line 289: private void initializeCommand(UpdateVmDiskParameters params) {
--
To view, visit http://gerrit.ovirt.org/15409
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I124176e8feb91b601a71e76dd63051648ec4353a
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
