Michael Pasternak has posted comments on this change.
Change subject: backend, restapi: Add read-only disk functionality
......................................................................
Patch Set 18:
(2 comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
Line 525: urlparams: {}
Line 526: headers:
Line 527: Content-Type: {value: application/xml|json, required: true}
Line 528: Correlation-Id: {value: 'any string', required: false}
Line 529: - name: /api/vms/{vm:id}/disks|rel=add
does ReadOnly relevant for /api/disks as well?
Line 530: description: add a new or existing disk to the virtual machine
Line 531: request:
Line 532: body:
Line 533: parameterType: Disk
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java
Line 147: model.setBootable(entity.isBoot());
Line 148: model.setPropagateErrors(PropagateErrors.On ==
entity.getPropagateErrors());
Line 149: model.setWipeAfterDelete(entity.isWipeAfterDelete());
Line 150: model.setActive(entity.getPlugged());
Line 151: model.setReadOnly(entity.getReadOnly());
i hope ReadOnly is reference type ...
Line 152: model.setShareable(entity.isShareable());
Line 153: if (entity.getDiskStorageType() == DiskStorageType.IMAGE) {
Line 154: mapDiskImageToDiskFields((DiskImage) entity, model);
Line 155: } else {
--
To view, visit http://gerrit.ovirt.org/15409
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I124176e8feb91b601a71e76dd63051648ec4353a
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
