Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Out-of-focus model refresh fix ......................................................................
Patch Set 1: This patch solves a bunch of NPEs, more precisely: org.ovirt.engine.ui.uicommonweb.models.quota.QuotaClusterListModel.SyncSearch(QuotaClusterListModel.java:35) org.ovirt.engine.ui.uicommonweb.models.quota.QuotaUserListModel.SyncSearch(QuotaUserListModel.java:73) org.ovirt.engine.ui.uicommonweb.models.quota.QuotaStorageListModel.SyncSearch(QuotaStorageListModel.java:35) org.ovirt.engine.ui.uicommonweb.models.datacenters.DataCenterStorageListModel.SyncSearch(DataCenterStorageListModel.java:209) org.ovirt.engine.ui.uicommonweb.models.hosts.HostInterfaceListModel.SyncSearch(HostInterfaceListModel.java:401) Some models in their SyncSearch() method first check if getEntity() != null. Models mentioned above don't do that. Maybe we can also fix the above models for potential NPEs, even though this patch avoids such NPEs to happen. -- To view, visit http://gerrit.ovirt.org/3847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9f45602681d9276b2a8d6a2b68a12dbbeba4b3b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
