Daniel Erez has submitted this change and it was merged. Change subject: webadmin,userportal: Out-of-focus model refresh fix ......................................................................
webadmin,userportal: Out-of-focus model refresh fix This patch fixes a regression where the "browser window out-of-focus" event caused all (main & detail) models to be started via GridTimer.setRefreshRate(). This is because GridTimer.setRefreshRate() calls reset(), which starts the timer again. So models which were not active were actually started via GridTimer.setRefreshRate(). This patch makes sure that when the "browser window out-of-focus" event happens, only models whose timers are active and not paused, have their refresh rate adjusted. This also removes some redundant methods from the GridController interface: getRefreshRate() and setRefreshRate(), both of which just delegate to GridTimer's methods via getTimer(). Change-Id: If9f45602681d9276b2a8d6a2b68a12dbbeba4b3b --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/GridController.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java 3 files changed, 26 insertions(+), 31 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9f45602681d9276b2a8d6a2b68a12dbbeba4b3b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
