Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: ignore non-working legacy pgpass ......................................................................
Patch Set 2: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/legacy/database.py Line 85: otopicons.CoreEnv.LOG_FILTER Line 86: ].append( Line 87: dbenv[osetupcons.DBEnv.PASSWORD] Line 88: ) Line 89: try: this is a little complicated... so a small comment here suggesting why the break is conditional will make it clear. but once again... I do not fully understand what we are trying to solve... if someone manually edited the file and added his own users? then how can we know the user we select is ours? maybe you should also check if the user is owner of database? Line 90: dbovirtutils = database.OvirtUtils(plugin=self) Line 91: dbovirtutils.tryDatabaseConnect(dbenv) Line 92: self.environment.update(dbenv) Line 93: break -- To view, visit http://gerrit.ovirt.org/21186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddad631ff679f3ba2e338c0925e046ff569b587e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
