Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: ignore non-working legacy pgpass ......................................................................
Patch Set 2: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/legacy/database.py Line 85: otopicons.CoreEnv.LOG_FILTER Line 86: ].append( Line 87: dbenv[osetupcons.DBEnv.PASSWORD] Line 88: ) Line 89: try: right. but then it like you say we have in /etc/ovirt-engine/engine.conf.d/*** that alter our behavior or any other left over at /etc you can argue the same for the existence of the ca certificate. and by adding osetupcons.CoreEnv.LEGACY_PG_CREDS_FOUND true in this patch you did not solve anything as it is as it will detect legacy upgrade. after cleanup versionLocked should be false and ca certificate should be removed, so we should not detect legacy upgrade. but I now beginning to understand the problem... the update of database credentials from legacy file should be done only if osetupcons.CoreEnv.UPGRADE_FROM_LEGACY in a stage after osetupcons.Stages.LEGACY_CORE_INIT. will it solve the problem? Line 90: dbovirtutils = database.OvirtUtils(plugin=self) Line 91: dbovirtutils.tryDatabaseConnect(dbenv) Line 92: self.environment.update(dbenv) Line 93: break -- To view, visit http://gerrit.ovirt.org/21186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddad631ff679f3ba2e338c0925e046ff569b587e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
