Piotr Kliczewski has posted comments on this change.
Change subject: engine : same exception is logged multiple times in engine log
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java
Line 180: case ERR_BAD_ADDR:
Line 181: outEx = new
VDSNetworkException(getReturnStatus().mMessage);
Line 182: break;
Line 183: default:
Line 184: log.errorFormat("Failed in {0} method", getCommandName());
In the lines that you mentioned we log but as you can see in both cases
different information and those particular log statements are not the issue as
described in 982686 bug.
Line 185: outEx = createException();
Line 186: log.errorFormat("Error code {0} and error message {1}",
returnStatus, outEx.getMessage());
Line 187: break;
Line 188: }
--
To view, visit http://gerrit.ovirt.org/21159
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbc476f1f5799967e5776ede3dcfd462eada2ce9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
