Arik Hadas has posted comments on this change.
Change subject: engine : same exception is logged multiple times in engine log
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java
Line 180: case ERR_BAD_ADDR:
Line 181: outEx = new
VDSNetworkException(getReturnStatus().mMessage);
Line 182: break;
Line 183: default:
Line 184: log.errorFormat("Failed in {0} method", getCommandName());
sorry, I missed the fact that there's a bug.. still, maybe I'm missing
something here but I see that the log that Alissa quoted there includes for
example:
2013-05-07 16:14:10,043 ERROR
[org.ovirt.engine.core.vdsbroker.vdsbroker.BrokerCommandBase]
(pool-4-thread-46) [105ad651] Error code imageErr and error message
VDSGenericException: VDSErrorException: Failed to VmReplicateDiskStartVDS, e
rror = Drive image file %s could not be found
2013-05-07 16:14:10,044 ERROR [org.ovirt.engine.core.vdsbroker.VDSCommandBase]
(pool-4-thread-46) [105ad651] Command VmReplicateDiskStartVDS execution failed.
Exception: VDSErrorException: VDSGenericException: VDSErrorException: Failed
to VmReplicateDiskStartVDS, error = Drive image file %s could not be found
the first message is printed in line #186 and the second in
VDSCommandBase#logException right?
IIUC, your fix will remove the second message, and the only information that
the first message contains and the second doesn't have is the error code. so
wouldn't it be better to include the error code in the exception message, and
just remove line 186 instead of introducing other kind of exception?
Line 185: outEx = createException();
Line 186: log.errorFormat("Error code {0} and error message {1}",
returnStatus, outEx.getMessage());
Line 187: break;
Line 188: }
--
To view, visit http://gerrit.ovirt.org/21159
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbc476f1f5799967e5776ede3dcfd462eada2ce9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
