Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: preserve shmmax config on cleanup ......................................................................
Patch Set 2: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-remove/system/sysctl.py Line 44: after=( Line 45: osetupcons.Stages.REMOVE_CUSTOMIZATION_GROUPS, Line 46: ), Line 47: ) Line 48: def _customization(self): Well, the self.environment[osetupcons.RemoveEnv.FILES_TO_REMOVE] list is populated at customization stage so I've added this at the same stage. But I've nothing against moving this to misc stage whit priority high. Do you think it's better having this at misc stage? Line 49: if ( Line 50: osetupcons.FileLocations.OVIRT_ENGINE_SYSCTL in Line 51: self.environment[osetupcons.RemoveEnv.FILES_TO_REMOVE] Line 52: ): -- To view, visit http://gerrit.ovirt.org/21139 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a95d5d9c678da80ee3f1e0a9de511309dfd4b51 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
