Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: preserve shmmax config on cleanup ......................................................................
Patch Set 2: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-remove/system/sysctl.py Line 44: after=( Line 45: osetupcons.Stages.REMOVE_CUSTOMIZATION_GROUPS, Line 46: ), Line 47: ) Line 48: def _customization(self): it is populated early as it is needed at customization phase for user interactions... I think the removal stage should have a name, and the manipulation of environment should be done at misc as well before the removal stage. The removal stage can be set at low priority then you do not need explicit dependency. oh... it is already at low... so you can just put it in misc. Line 49: if ( Line 50: osetupcons.FileLocations.OVIRT_ENGINE_SYSCTL in Line 51: self.environment[osetupcons.RemoveEnv.FILES_TO_REMOVE] Line 52: ): -- To view, visit http://gerrit.ovirt.org/21139 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a95d5d9c678da80ee3f1e0a9de511309dfd4b51 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
