Liron Ar has posted comments on this change. Change subject: engine: Remove concreteStorageType property from StorageType enum. ......................................................................
Patch Set 3: @Tal The test doesn't check if you update the "isConcreteStorageType" method. I'm against this approach and think that this boolean cost us nothing which it "forces" each programmer to write this property explicitly. Anyway, I'm not sure how much we can and should "protect" ourselves. To sum up, i'm in favour of leaving as is and i don't see any benefit from removing it but you want to merge it, go ahead. -- To view, visit http://gerrit.ovirt.org/21312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdd785ccb3c0e074f5a14bec1ee60c6d374700a1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
