Liron Ar has posted comments on this change. Change subject: engine: Remove concreteStorageType property from StorageType enum. ......................................................................
Patch Set 3: @Sergey, if we had it..i don't think that it's bad, it's just the thing that prevents mistakes which it's cost is basically zero. As i said, that how i prefer it - as there's no bug i'm not blocking this change..if a maintainer thinks it's better approach and you want it that way, so be it. -- To view, visit http://gerrit.ovirt.org/21312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdd785ccb3c0e074f5a14bec1ee60c6d374700a1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
