Alissa Bonas has uploaded a new change for review. Change subject: core: rename methods in vds commands. ......................................................................
core: rename methods in vds commands. Rename to lowercase to solve findbugs warning. Change-Id: I0e63ad7d330fb46a18c3e711167f52652ec6ffd3 Signed-off-by: Alissa Bonas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupOperationCommandBase.java 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/38/21338/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java index bee280e..1645d08 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java @@ -34,7 +34,7 @@ @Override protected void executeCommand() { - CheckMaxMemoryOverCommitValue(); + checkMaxMemoryOverCommitValue(); getVdsGroup().setDetectEmulatedMachine(true); DbFacade.getInstance().getVdsGroupDao().save(getVdsGroup()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java index 713698b..d1e0e7b 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java @@ -54,7 +54,7 @@ @Override protected void executeCommand() { // TODO: This code should be revisited and proper compensation logic should be introduced here - CheckMaxMemoryOverCommitValue(); + checkMaxMemoryOverCommitValue(); if (!ObjectUtils.objectsEqual(oldGroup.getcompatibility_version(), getParameters().getVdsGroup().getcompatibility_version())) { String emulatedMachine = null; // pick an UP host randomly - all should have latest compat version already if we passed the canDo. diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupOperationCommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupOperationCommandBase.java index f666bfb..d98d69e 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupOperationCommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupOperationCommandBase.java @@ -35,7 +35,7 @@ return getParameters().getVdsGroup(); } - protected void CheckMaxMemoryOverCommitValue() { + protected void checkMaxMemoryOverCommitValue() { if (getVdsGroup().getmax_vds_memory_over_commit() <= 0) { getVdsGroup().setmax_vds_memory_over_commit( Config.<Integer> GetValue(ConfigValues.MaxVdsMemOverCommit)); -- To view, visit http://gerrit.ovirt.org/21338 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0e63ad7d330fb46a18c3e711167f52652ec6ffd3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
