Liron Ar has posted comments on this change.
Change subject: core: Storage activation error fix
......................................................................
Patch Set 3:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java
Line 140:
Line 141: private boolean storageDomainStatusIsValid() {
Line 142: if (getStorageDomainStatus() == StorageDomainStatus.Active) {
Line 143: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_ALREADY_ACTIVE);
Line 144: }
I don't think that it's necessary to add a new message, just changing the
current one will "fix" the wrong message for all the statuses and will
changes/messages - otherwise tomorrow we might have a bug on activating domain
which is locked (we will get again the message that it's inaccessible), the
problem imo is the message content, not the fact that we have unified message
for that scenario.
Line 145:
Line 146: if (isInternalExecution()) {
Line 147: return
checkStorageDomainStatus(StorageDomainStatus.InActive,
StorageDomainStatus.Unknown,
Line 148: StorageDomainStatus.Locked,
StorageDomainStatus.Maintenance);
--
To view, visit http://gerrit.ovirt.org/21320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe8ad96a5bd40adb56b7a63c4ae5ef75a550e5b2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Cheryn Tan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
