Allon Mureinik has posted comments on this change.
Change subject: core: Storage activation error fix
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
See question inline
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
Line 172: return valid;
Line 173: }
Line 174:
Line 175: protected boolean
checkStorageDomainStatusNotEqual(StorageDomainStatus status) {
Line 176: if (getStorageDomainStatus() != null &&
getStorageDomainStatus() != status) {
how can getStorageDomainStatus() ever be null?
Line 177: addStorageDomainStatusIllegalMessage();
Line 178: return true;
Line 179: }
Line 180: return false;
--
To view, visit http://gerrit.ovirt.org/21320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe8ad96a5bd40adb56b7a63c4ae5ef75a550e5b2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Cheryn Tan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
