Gilad Chaplik has posted comments on this change. Change subject: webadmin: Gluster Create Volume dialog changes ......................................................................
Patch Set 1: (9 inline comments) some comments inline .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java Line 17: getReplicaCount().setEntity(2); use constants Line 21: getStripeCount().setEntity(4); same here .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java Line 117: getReplicaCount().setEntity(2); same. Line 121: getStripeCount().setEntity(4); same Line 132: I see that there is 2 event registrations for getTypeList().getSelectedItemChangedEvent() remove one? Line 135: getAddBricksCommand().Execute(); when changing the volume type a popup will be opened? Line 250: volumeBrickModel.getReplicaCount().setEntity(this.getReplicaCount().getEntity()); why do you use 'this' keyword here? if there is no reason remove it (several places) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java Line 283: volume.setStripeCount(Integer.parseInt((String) model.getStripeCount().getEntity())); why's stripe count is saved as String? .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.java Line 98: table.setRowData(new ArrayList<ListModel>()); why you need this line? table.setRowData(new ArrayList<ListModel>()); -- To view, visit http://gerrit.ovirt.org/3899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61163b772c97f70ab055583efd54bc8bfbaafe04 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
