Gilad Chaplik has posted comments on this change. Change subject: webadmin: Gluster Create Volume dialog changes ......................................................................
Patch Set 1: (4 inline comments) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java Line 17: getReplicaCount().setEntity(2); class is ok, but give a meaningful name, if you use it in other places (as I know you do) set it to 'public static' I think you should put it in the VolumeListModel class. .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java Line 135: getAddBricksCommand().Execute(); Done Line 250: volumeBrickModel.getReplicaCount().setEntity(this.getReplicaCount().getEntity()); and this .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java Line 283: volume.setStripeCount(Integer.parseInt((String) model.getStripeCount().getEntity())); ctor: EntityModelTextBoxEditor(Renderer<Object> renderer, Parser<Object> parser) -- To view, visit http://gerrit.ovirt.org/3899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61163b772c97f70ab055583efd54bc8bfbaafe04 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
