Eoghan Glynn has posted comments on this change. Change subject: restapi: Added Gluster entities in REST schema ......................................................................
Patch Set 11: (2 inline comments) Couple of minor nit-picks on the XSD changes in comments inline. .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 24: Lots of white-space changes here, I would have split out to a separate small patch. Not a biggie though. Line 2430: <xs:element name="stripe_count" type="xs:int" minOccurs="0" maxOccurs="1"/> The two counts should be modelled as xs:unsignedInt (just for clarity, its unenforced in the Java mapping). -- To view, visit http://gerrit.ovirt.org/3360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93c4df85068c3ed1ebfa35124bdfc2ae8f4482c8 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Eoghan Glynn <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
