Ori Liel has posted comments on this change. Change subject: restapi: Added Gluster entities in REST schema ......................................................................
Patch Set 20: Looks good to me, but someone else must approve (1 inline comment) Michael Pasternak also wants to go over the patches. In the meantime, +1 for me, the patch looks great; I wouldn't change anything :) .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java Line 185: } Just to make sure - volume and brick have the same possible states (UP, DOWN), and that's why they can 'share' the enum GlusterState? -- To view, visit http://gerrit.ovirt.org/3360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93c4df85068c3ed1ebfa35124bdfc2ae8f4482c8 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Eoghan Glynn <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
