Mike Kolesnik has posted comments on this change.
Change subject: core: [Fix] Add host hotplug support checks
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
Line 395: }
Line 396:
Line 397: protected boolean canPerformNicHotPlug() {
Line 398: return isHotPlugSupported()
Line 399: && osRepository.hasNicHotplugSupport(getVm().getOs(),
getVm().getVdsGroupCompatibilityVersion());
If OS is not supporting NIC hotplug, in the current implementation the user
will not get an error at all and will not know that this is the reason the
action failed..
I suggest to add a check if there is no NIC hotplug support then:
return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_GUEST_OS_VERSION_IS_NOT_SUPPORT
ED);
Line 400: }
Line 401:
Line 402: /**
Line 403: * check that hotplug is enabled via the 3.1 config paramter
{@literal ConfigValues.HotPlugEnabled,
--
To view, visit http://gerrit.ovirt.org/21266
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e4c8409c0de4ff1c959d27b54e793a31654326c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: liron aravot <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
