Martin Peřina has posted comments on this change.
Change subject: core: Move VDS to Maintenance only if StopSPM is successful
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java
Line 94: if (vds.getStatus() != VDSStatus.PreparingForMaintenance
&& vds.getStatus() != VDSStatus.NonResponsive
Line 95: && vds.getStatus() != VDSStatus.Down) {
Line 96: VDSReturnValue result =
runVdsCommand(VDSCommandType.SetVdsStatus,
Line 97: new
SetVdsStatusVDSCommandParameters(vds.getId(),
VDSStatus.PreparingForMaintenance));
Line 98: if (!result.getSucceeded()) {
Testing: Well, I tested it by blocking SPM host using iptables, so it first
went to NonResponsive and when I unblocked it, it went to Up because
VdsUpdateRuntimeInfo. Do you have any idea how to test this case without
blocking the host with iptables?
Logging: Well, SetVdsStatus is VDSCommand, so it doesn't have built-in support
for AuditLog. But when I looked into it, it could be easily moved to BLL
command (it only updates DB and execute ResetIrs command for SPM hosts). What
do you think?
Line 99: // remove VDS from base list, because of an error
during SetVdsStatus
Line 100: vdssToMaintenance.remove(vds.getId());
Line 101:
Line 102: AuditLogableBase base = new AuditLogableBase();
--
To view, visit http://gerrit.ovirt.org/21231
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c58f9a9629d2e7a496f02c4dececeb842d44543
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
