Ravi Nori has posted comments on this change.
Change subject: engine : Validate parameter in canDoAction
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 2164: }
Line 2165:
Line 2166: protected void setRequiredParameters(VdcParameter[] params) {
Line 2167: this.requiredParameters = Arrays.asList(params);
Line 2168: }
I was trying to follow the style in restapi
Please see BackendHostsResource in api package.
Line 2169:
Line 2170: protected void setOptionalParameters(VdcParameter[] params) {
Line 2171: this.optionalParameters = Arrays.asList(params);
Line 2172: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VdcParametersValidator.java
Line 79: buf.append(param.getName());
Line 80: }
Line 81: log.warnFormat("Unknown parameters {0} found in command.",
buf.toString());
Line 82: }
Line 83: return true;
Throws exception on failure, returns true on success. Will re-factor this code
Line 84: }
Line 85:
--
To view, visit http://gerrit.ovirt.org/21485
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15566c9177da28b2d47bbb6018fbfb61defcf3da
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
