Ravi Nori has posted comments on this change.
Change subject: engine : Validate parameter in canDoAction
......................................................................
Patch Set 1:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 2164: }
Line 2165:
Line 2166: protected void setRequiredParameters(VdcParameter[] params) {
Line 2167: this.requiredParameters = Arrays.asList(params);
Line 2168: }
I will look into bean type auto completion per Barak's suggestion. Will update
in latter patch
Line 2169:
Line 2170: protected void setOptionalParameters(VdcParameter[] params) {
Line 2171: this.optionalParameters = Arrays.asList(params);
Line 2172: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VdcParametersValidator.java
Line 42: CoreVdcParameters.FILTERED,
Line 43: CoreVdcParameters.REFRESH};
Line 44: private static final List<VdcParameter> commonParameters =
Arrays.asList(commonParametersArray);
Line 45:
Line 46: public static <T extends VdcParametersMap> boolean
validateParameters(
removed
Line 47: T parameters,
Line 48: List<VdcParameter> requiredParameters,
Line 49: List<VdcParameter> optionalParameters) {
Line 50: Set<Map.Entry<VdcParameter, Serializable>> paramsSet =
parameters.entrySet();
Line 51: List<VdcParameter> paramNames = new ArrayList<VdcParameter>();
Line 52: for (Map.Entry<VdcParameter, Serializable> param : paramsSet) {
Line 53: paramNames.add(param.getKey());
Line 54: try {
Line 55: if
(!Class.forName(param.getKey().getJavaType()).isAssignableFrom(param.getValue().getClass()))
{
removed java type checking and moved to VdcParameter
Line 56: throw new
InvalidParameterValueException(param.getKey().getName(),
param.getKey().getJavaType(), param.getValue().getClass().getName());
Line 57: }
Line 58: } catch (ClassNotFoundException e) {
Line 59: throw new
InvalidParameterValueException(param.getKey().getName(),
param.getKey().getJavaType());
--
To view, visit http://gerrit.ovirt.org/21485
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15566c9177da28b2d47bbb6018fbfb61defcf3da
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
