Liron Ar has posted comments on this change.
Change subject: core: don't skip storagePoolStatusChange call
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 591: // If VDS is in initialize status, wait for it to be up
(or until
Line 592: // configurable timeout is reached)
Line 593: waitForVdsIfIsInitializing(curVdsId);
Line 594: // update pool status to problematic while selecting spm
Line 595: try {
My point was somehow missed-
1. In the scenario of the bug, the status of the pool is already NonResponsive
|| NonOperational while the spm is not responsive - in that scenario, the
domain status will keep flipping between active and unknown which isn't good
imo and is bad user experience,
other host can't be selected in the bug scenario as spm as the spm isn't
released and the spm host is non reponsive.
2.I think that the fixes to SetStoragePoolStatus (avoiding synchronized/etc) is
related to this patch and should be part of this patch, not a follow up patch
as the calls are being added here.
Line 596: ResourceManager
Line 597: .getInstance()
Line 598: .getEventListener()
Line 599: .storagePoolStatusChange(_storagePoolId,
StoragePoolStatus.NonResponsive,
--
To view, visit http://gerrit.ovirt.org/20527
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I37741911c8e22f7534516d3ed8bccca6b311dc92
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
