Liron Ar has posted comments on this change.
Change subject: core: don't skip storagePoolStatusChange call
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 591: // If VDS is in initialize status, wait for it to be up
(or until
Line 592: // configurable timeout is reached)
Line 593: waitForVdsIfIsInitializing(curVdsId);
Line 594: // update pool status to problematic while selecting spm
Line 595: try {
Suggestions :
1. Quick - you can look into setting the pool status in that scenario to non
operational instead of non reponsive, iirc domain monitoring info isn't being
considered while the pool is non op and that should fix it... i'm not sure if
there will be implications on other flows (currently, i see that non op is
being used when failing to fence the spm..so it makes some sense to have it in
that scenario).
2. The domain monitoring logic could be changed, but i guess that it's larger
refactor that you wouldn't want to handle here.
Line 596: ResourceManager
Line 597: .getInstance()
Line 598: .getEventListener()
Line 599: .storagePoolStatusChange(_storagePoolId,
StoragePoolStatus.NonResponsive,
--
To view, visit http://gerrit.ovirt.org/20527
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I37741911c8e22f7534516d3ed8bccca6b311dc92
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
