Gilad Chaplik has posted comments on this change.
Change subject: webadmin: version in feedback url.
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Alex,
minor comments, for your consideration.
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/HeaderPresenterWidget.java
Line 112: getView().setFeedbackText(feedbackLinkLabel);
Line 113:
registerHandler(getView().getFeedbackLink().addClickHandler(new ClickHandler() {
Line 114: @Override
Line 115: public void onClick(ClickEvent event) {
Line 116:
WebUtils.openUrlInNewWindow(feedbackLinkLabel, feedbackUrl);
Maybe worth adding the version to the label as well (feedback (version: XYZ),
so we'll have justification for fetching the version :-) (in case there isn't
any placeholder in the feedback_url, like in oVirt brand)
Line 117: }
Line 118: }));
Line 119: }
Line 120: }
Line 118: }));
Line 119: }
Line 120: }
Line 121: };
Line 122: AsyncDataProvider.getRpmVersionViaPublic(_asyncQuery);
Can we change it to !public? I remember we used to fetch the version when we're
not loged-in, but I can't find it anymore.
Line 123: }
--
To view, visit http://gerrit.ovirt.org/21738
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7f4305ff1e3bd30aa13f1ba381186cf9e910c71
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
