Alexander Wels has posted comments on this change.
Change subject: webadmin: version in feedback url.
......................................................................
Patch Set 1:
(2 comments)
@Einav can you answer the question about if we should add the version option to
the feedback label as well?
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/HeaderPresenterWidget.java
Line 112: getView().setFeedbackText(feedbackLinkLabel);
Line 113:
registerHandler(getView().getFeedbackLink().addClickHandler(new ClickHandler() {
Line 114: @Override
Line 115: public void onClick(ClickEvent event) {
Line 116:
WebUtils.openUrlInNewWindow(feedbackLinkLabel, feedbackUrl);
It is a pretty trivial change to add that, I am adding this ability so branding
themes can add the version to their feedback URL if they want. If we want the
ability to add it to the feedback label as well it is easy to add.
@Einav do we want to give the ability to add the version to the label as well?
Line 117: }
Line 118: }));
Line 119: }
Line 120: }
Line 118: }));
Line 119: }
Line 120: }
Line 121: };
Line 122: AsyncDataProvider.getRpmVersionViaPublic(_asyncQuery);
A quick search indicates we use this method here and in the about dialog and
nowhere else, I will change it to be non public.
Line 123: }
--
To view, visit http://gerrit.ovirt.org/21738
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7f4305ff1e3bd30aa13f1ba381186cf9e910c71
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
