Martin Sivák has uploaded a new change for review.

Change subject: core: Check if balloon device is present in stalled ballon check
......................................................................

core: Check if balloon device is present in stalled ballon check

Check for stalled balloon (inflated but uncontrolable) accesses
balloon data. That might cause Null pointer exception when
the device is not there or we do not have all needed information.

Change-Id: Ie9074fc67913e3c5ad9ad81744bfe4de27a19636
Bug-Url: https://bugzilla.redhat.com/??????
Signed-off-by: Martin Sivak <[email protected]>
---
M 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/83/21783/1

diff --git 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
index 9a28736..e372f5b 100644
--- 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
+++ 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
@@ -1303,6 +1303,7 @@
 
                 if (vmInternalData.getVmStatistics().getusage_mem_percent() != 
null
                     && vmInternalData.getVmStatistics().getusage_mem_percent() 
== 0  // guest agent is down
+                        && balloonInfo.isBalloonDeviceEnabled() // check if 
the device is present
                         && balloonInfo.getCurrentMemory().intValue() != 
balloonInfo.getBalloonMaxMemory().intValue()) {
                     guestAgentIsDownAndBalloonInfalted(vmId);
                 } else {


-- 
To view, visit http://gerrit.ovirt.org/21783
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie9074fc67913e3c5ad9ad81744bfe4de27a19636
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to