Gilad Chaplik has posted comments on this change.
Change subject: core: Check if balloon device is present in stalled ballon check
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 1303:
Line 1304: if
(vmInternalData.getVmStatistics().getusage_mem_percent() != null
Line 1305: &&
vmInternalData.getVmStatistics().getusage_mem_percent() == 0 // guest agent is
down
Line 1306: && balloonInfo.isBalloonDeviceEnabled() //
check if the device is present
Line 1307: && balloonInfo.getCurrentMemory().intValue()
!= balloonInfo.getBalloonMaxMemory().intValue()) {
btw, we should use Objects.equals (objectUtils.eqauls is deprecated). the only
problem I have with this change is comparing 2 nulls (return true), but now we
get NPE for it (so I guess that is better). I'd replace it in all
*balloon*.intValue() comparisments
Line 1308: guestAgentIsDownAndBalloonInfalted(vmId);
Line 1309: } else {
Line 1310: guestAgentIsUpOrBalloonDeflated(vmId);
Line 1311: }
--
To view, visit http://gerrit.ovirt.org/21783
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9074fc67913e3c5ad9ad81744bfe4de27a19636
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
