Liron Ar has posted comments on this change.
Change subject: core: Move VDS to Maintenance only if StopSPM is successful
......................................................................
Patch Set 5:
(2 comments)
comments also in previous patchset
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java
Line 38
Line 39
Line 40
Line 41
Line 42
how's this refactor related to this change?
Line 146:
Line 147: @Override
Line 148: protected boolean canDoAction() {
Line 149: boolean result = true;
Line 150: Set<Guid> clustersAsSet = new HashSet<Guid>();
why/how this refactor is related to this change?
Line 151: Set<Guid> vdsWithRunningVMs = new HashSet<Guid>();
Line 152: List<String> hostNotRespondingList = new ArrayList<String>();
Line 153: List<String> hostsWithNonMigratableVms = new
ArrayList<String>();
Line 154: List<String> hostsWithVmsWithPluggedDiskSnapshots = new
ArrayList<>();
--
To view, visit http://gerrit.ovirt.org/21231
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c58f9a9629d2e7a496f02c4dececeb842d44543
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
