Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: update firewall for all services ......................................................................
Patch Set 23: (2 comments) .................................................... File packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager_firewalld.py Line 44: Firewall manager firewalld plugin. Line 45: """ Line 46: Line 47: @staticmethod Line 48: def parseFirewalld(format, environment, portSeparator='-'): if you decide to put it in this module move it out of the plugin class and add @export, and import it at other modules. I prefer putting this at its own module, but it is the same effect, on consumer import only this function from this module. Line 49: ret = '' Line 50: for content in [ Line 51: content Line 52: for key, content in environment.items() .................................................... File packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager_human.py Line 31: from ovirt_engine_setup import constants as osetupcons Line 32: from ovirt_engine_setup import firewall_manager_base Line 33: Line 34: Line 35: from . import firewall_manager_firewalld import the specific function? Line 36: Line 37: Line 38: @util.export Line 39: class Plugin(plugin.PluginBase): -- To view, visit http://gerrit.ovirt.org/20737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
