Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: update firewall for all services
......................................................................
Patch Set 25:
(3 comments)
....................................................
File
packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager_human.py
Line 54: def detect(self):
Line 55: return True
Line 56:
Line 57: def selectable(self):
Line 58: return False
I think you need only this one
Line 59:
Line 60: def active(self):
Line 61: return False
Line 62:
Line 63: def enable(self):
Line 64: pass
Line 65:
Line 66: def prepare(self):
Line 67: pass
you do not need these function as exist at base
Line 68:
Line 69: def print_manual_configuration_instructions(self):
Line 70: ports = '\n'.join(
Line 71: sorted(
Line 66: def prepare(self):
Line 67: pass
Line 68:
Line 69: def print_manual_configuration_instructions(self):
Line 70: ports = '\n'.join(
no need for ports temp var :)
Line 71: sorted(
Line 72: parseFirewalld(
Line 73: format=' {protocol}:{port}\n',
Line 74: environment=self.environment,
--
To view, visit http://gerrit.ovirt.org/20737
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9
Gerrit-PatchSet: 25
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
