Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: update firewall for all services ......................................................................
Patch Set 26: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py Line 217: # constants.Stages.IPTABLES_VALIDATION, Line 218: #), Line 219: # and remove: Line 220: priority=plugin.Stages.PRIORITY_HIGH, Line 221: ) did what the TODO said. Why don't we need it? Line 222: def _validation(self): Line 223: if self.environment[ Line 224: osetupcons.ConfigEnv.FIREWALL_MANAGER Line 225: ] not in [m.name for m in self._available_managers]: -- To view, visit http://gerrit.ovirt.org/20737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9 Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
