Eoghan Glynn has posted comments on this change.

Change subject: restapi: Gluster REST api - Create Gluster Volume
......................................................................


Patch Set 3: I would prefer that you didn't submit this

Hi Shireesh,

I would like to see a unit test for BackendGlusterVolumesResource.add(), with 
appropriate use of the mocking patterns used widely across the units for the 
other resource implementations.

Thanks,
Eoghan

--
To view, visit http://gerrit.ovirt.org/3932
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I578f5b7ea0328057d2e29d04a31393856b021f08
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Eoghan Glynn <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to