Ori Liel has posted comments on this change.
Change subject: restapi: Gluster REST api - Create Gluster Volume
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumesResource.java
Line 49:
since Gluster Bricks are business entities, they will be added in the context:
.../volumes/{volume:id}/bricks
(not here, which is):
.../volumes/{volume:id}
So we shouldn't verify that the user passed bricks; in fact the user will never
pass bricks in this context.
This raises the question of what does it mean to create, temporarily, a volume
without bricks, and then add bricks to it. Basically, creating an 'empty'
volume.
We had the same debate recently for Quotas - a Quota has limitations. The
limitations are business-entities in their own right, but a Quota with no
limitation is meaningless. We eventually decided that creating an 'empty'
quota, and adding limitations to it afterwards, is legal. Do you think we can
make the same decision here?
--
To view, visit http://gerrit.ovirt.org/3932
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I578f5b7ea0328057d2e29d04a31393856b021f08
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Eoghan Glynn <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
