Yair Zaslavsky has uploaded a new change for review. Change subject: core: Fix potential NPE ......................................................................
core: Fix potential NPE Thie defect was reported by Coverity Change-Id: I6fdb4c5991be781c05c05e92e74bac19c0382bb9 Signed-off-by: Yair Zaslavsky <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerBase.java 1 file changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/82/22282/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerBase.java index ca0be21..9ae5850 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerBase.java @@ -1,21 +1,27 @@ package org.ovirt.engine.core.bll.adbroker; +import org.ovirt.engine.core.utils.ReflectionUtils; import org.ovirt.engine.core.utils.log.Log; import org.ovirt.engine.core.utils.log.LogFactory; -import org.ovirt.engine.core.utils.ReflectionUtils; public abstract class LdapBrokerBase implements LdapBroker { private static final String CommandsContainerAssemblyName = LdapBrokerBase.class.getPackage().getName(); private static final String CommandPrefix = "Command"; private static Log log = LogFactory.getLog(LdapBrokerBase.class); + private static LdapReturnValueBase failureResponse = null; protected abstract String getBrokerType(); + + static { + failureResponse = new LdapReturnValueBase(); + failureResponse.setSucceeded(false); + } public LdapReturnValueBase runAdAction(AdActionType actionType, LdapBrokerBaseParameters parameters) { log.debug("runAdAction Entry, actionType=" + actionType.toString()); BrokerCommandBase command = CreateCommand(actionType, parameters); - return command.execute(); + return command != null ? command.execute() : failureResponse; } private BrokerCommandBase CreateCommand(AdActionType action, LdapBrokerBaseParameters parameters) { -- To view, visit http://gerrit.ovirt.org/22282 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6fdb4c5991be781c05c05e92e74bac19c0382bb9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
