Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Dashboard results an error, when reports is not
deployed
......................................................................
Patch Set 1:
(1 comment)
Can you move the code to the presenter?
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabReportsView.java
Line 27: PostableFrame reportPostableFrame;
Line 28:
Line 29: private static final String REPORTS_WEBAPP_ERROR_MSG = "Error
getting status of Reports Webapp"; //$NON-NLS-1$
Line 30: private static final String REPORTS_WEBAPP_DEPLOYED_MSG = "Reports
Webapp Deployed"; //$NON-NLS-1$
Line 31: private static final String REPORTS_WEBAPP_NOT_DEPLOYED_MSG =
"Reports Webapp not deployed, please try later."; //$NON-NLS-1$
Please localize the strings
Line 32: private static boolean reportsWebappDeployed = false;
Line 33: private static ErrorPopupManager errorPopupManager;
Line 34:
Line 35: interface MainTabReportsViewUiBinder extends UiBinder<Widget,
MainTabReportsView> {
--
To view, visit http://gerrit.ovirt.org/22279
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6f63fe75110a6f799d355e78ed1fc0af2bd7d06
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
