Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Dashboard results an error, when reports is not
deployed
......................................................................
Patch Set 2:
(3 comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabReportsPresenter.java
Line 69:
Line 70: private void checkUpdateReportsPanel(final String url,
Line 71: final Map<String,
List<String>> params) {
Line 72: if (errorPopupManager == null) {
Line 73: errorPopupManager = (ErrorPopupManager)
TypeResolver.getInstance().resolve(ErrorPopupManager.class);
better to inject it in the ctor and mark the field as final.
Line 74: }
Line 75: if (applicationConstants == null) {
Line 76: applicationConstants =
GWT.create(ApplicationConstants.class);
Line 77: }
Line 72: if (errorPopupManager == null) {
Line 73: errorPopupManager = (ErrorPopupManager)
TypeResolver.getInstance().resolve(ErrorPopupManager.class);
Line 74: }
Line 75: if (applicationConstants == null) {
Line 76: applicationConstants =
GWT.create(ApplicationConstants.class);
better to inject it in the ctor and mark the field as final.
Line 77: }
Line 78: RequestBuilder requestBuilder =
Line 79: new RequestBuilder(RequestBuilder.GET,
buildStatusUrl(url)); //$NON-NLS-1$
Line 80: try {
Line 117: super.onReset();
Line 118: if (!hasReportsModelRefreshEvent()) {
Line 119: reportsWebappDeployed = false;
Line 120: getModel().getReportModelRefreshEvent().addListener(new
ReportsModelRefreshEvent());
Line 121: }
can we lose the event registration?
Line 122: setSubTabPanelVisible(false);
Line 123: getModel().refreshReportModel();
Line 124: }
Line 125:
--
To view, visit http://gerrit.ovirt.org/22279
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6f63fe75110a6f799d355e78ed1fc0af2bd7d06
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
