Yair Zaslavsky has posted comments on this change. Change subject: core: Introduce new authentication interfaces ......................................................................
Patch Set 8: (2 comments) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/authentication/AuthenticationProfileFactory.java Line 1: package org.ovirt.engine.core.authentication; Line 2: Line 3: import java.io.File; Line 4: Line 5: import org.slf4j.Logger; +1 Line 6: import org.slf4j.LoggerFactory; Line 7: Line 8: /** Line 9: * An authentication profile is just a pair composed of an authenticator and a directory so this class just looks up Line 33: "the name of the profile.", Line 34: config.getAbsoluteKey(NAME_PARAMETER), Line 35: file.getAbsolutePath() Line 36: ); Line 37: return null; IMHO would be better, what do you think? Line 38: } Line 39: Line 40: // Try to load the authenticator configuration: Line 41: Configuration authenticatorView = config.getView(AUTHENTICATOR_PARAMETER); -- To view, visit http://gerrit.ovirt.org/15596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If84a0c9d6553d81cdbbe224972696f169cca90d4 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
