Juan Hernandez has posted comments on this change.
Change subject: core: Introduce new authentication interfaces
......................................................................
Patch Set 8:
(2 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/authentication/AuthenticationProfileFactory.java
Line 33: "the name of the profile.",
Line 34: config.getAbsoluteKey(NAME_PARAMETER),
Line 35: file.getAbsolutePath()
Line 36: );
Line 37: return null;
Ok, I am introducing that exception and throwing it instead of returning null
when something isn't correct. Not only in this particular place, but in general.
Line 38: }
Line 39:
Line 40: // Try to load the authenticator configuration:
Line 41: Configuration authenticatorView =
config.getView(AUTHENTICATOR_PARAMETER);
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/authentication/Managed.java
Line 3: /**
Line 4: * This is a base interface for all managed objects (directories,
authenticators and profiles) included in this package.
Line 5: * The only thing that all these have in common is that they are
managed and that they have a name.
Line 6: */
Line 7: public interface Managed {
I have already removed this interface.
Line 8: /**
Line 9: * Returns the name of the object, which usually is the name of the
underlying mechanism, for example, for an LDAP
Line 10: * directory service the name should be based on the suffix of the
LDAP database, so if the suffix is
Line 11: * {@code dc=example,dc=com} then the name should be {@code
example.com}. However this is not enforced at all,
--
To view, visit http://gerrit.ovirt.org/15596
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If84a0c9d6553d81cdbbe224972696f169cca90d4
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
